-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qml.QDrift
template
#4671
qml.QDrift
template
#4671
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions and Reminders
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4671 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 377 378 +1
Lines 34015 33810 -205
==========================================
- Hits 33894 33688 -206
- Misses 121 122 +1
☔ View full report in Codecov by Sentry. |
[sc-43477] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 😊
And thanks for adding the error, I forgot it in the draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow what a great PR, who ever coded this must be a really good developer 💯!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KetpuntoG and @Jaybsoni. Will approve when my final small comments are addressed.
Note: I have left in comments some doubts
Context:
Third of 3 PRs adding the new QDrift template to allow for advanced Trotter methods in Pennylane
Description of the Change:
Implement the template
Quick test to show that the solution is correct
It has been checked if at infinity (n = 10000) it converges to the exact value.
Running it shows that the three matrices are equal