Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility for extracting classical control information to drawer #4917

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Dec 5, 2023

This PR replaces find_mid_measure_cond_connections with cwire_connections. It returns very similar information, but is a slight variant that will be easier to use in the matplotlib drawing of classical wires.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45d5e9d) 99.66% compared to head (2c1cb79) 99.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4917      +/-   ##
==========================================
- Coverage   99.66%   99.65%   -0.02%     
==========================================
  Files         387      387              
  Lines       35050    34782     -268     
==========================================
- Hits        34933    34662     -271     
- Misses        117      120       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro albi3ro requested a review from a team December 6, 2023 15:12
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Christina! Looks significantly more polished than my original implementation 😄

pennylane/drawer/utils.py Show resolved Hide resolved
pennylane/drawer/tape_text.py Outdated Show resolved Hide resolved
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@albi3ro albi3ro requested a review from a team December 6, 2023 16:05
@albi3ro
Copy link
Contributor Author

albi3ro commented Dec 6, 2023

[sc-51624]

Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@albi3ro albi3ro enabled auto-merge (squash) December 6, 2023 17:27
@albi3ro albi3ro merged commit 5dbe233 into master Dec 6, 2023
35 checks passed
@albi3ro albi3ro deleted the cwire-connections branch December 6, 2023 21:55
mudit2812 added a commit that referenced this pull request Dec 7, 2023
…4917)

This PR replaces `find_mid_measure_cond_connections` with
`cwire_connections`. It returns very similar information, but is a
slight variant that will be easier to use in the matplotlib drawing of
classical wires.

---------

Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812 added a commit that referenced this pull request Jan 19, 2024
…4917)

This PR replaces `find_mid_measure_cond_connections` with
`cwire_connections`. It returns very similar information, but is a
slight variant that will be easier to use in the matplotlib drawing of
classical wires.

---------

Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants