Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qutrit mixed apply operation #5032

Merged
merged 111 commits into from
Jan 29, 2024

Conversation

Gabriel-Bottrill
Copy link
Contributor

@Gabriel-Bottrill Gabriel-Bottrill commented Jan 10, 2024

Context:
Currently the qutrit_mixed device is being developed this is a necessary addition to the overall project as this applies operations to a qutrit mixed state. This is a prerequisite for other functionality relating to the qutrit mixed device for noisy qutrit simulation.

Description of the Change:
Added functionality for applying operations to a qutrit mixed-state. The new apply_operation function can be used to apply gates and Channels to a qutrit mixed-state.

Benefits:
Allows for Channels and operations to be applied to a mixed state, will be used to add execute functionality to qutrit mixed-state device allowing for noisy qutrit simulation

Possible Drawbacks:
Abstracting for qubits and more generally qutrits may have added challenges and will require a reforctor or copied code code-smell.

Related GitHub Issues:
N/A

Copy link
Contributor

@glassnotes glassnotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates so far! Just finished reviewing, and added some comments for the test files.

pennylane/devices/qutrit_mixed/apply_operation.py Outdated Show resolved Hide resolved
pennylane/devices/qutrit_mixed/utils.py Show resolved Hide resolved
pennylane/devices/qutrit_mixed/apply_operation.py Outdated Show resolved Hide resolved
Copy link
Contributor

@glassnotes glassnotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the changes! This is good to go from my end, just the one documentation update to make.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Reminder to resolve pending comments. Nice work @Gabriel-Bottrill

Gabriel-Bottrill and others added 5 commits January 22, 2024 16:10
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@Gabriel-Bottrill
Copy link
Contributor Author

@albi3ro, I had to use your suggestion to input jax.config.update("jax_enable_x64", True) at the start of failing tests, if you are ok with that and the PR, would you please merge it or let me know what to do. Thanks!

@trbromley
Copy link
Contributor

@Gabriel-Bottrill, we're good to go to merge this! Would you mind updating your branch as it's a blocker for merging.

@trbromley trbromley enabled auto-merge (squash) January 29, 2024 14:12
@glassnotes
Copy link
Contributor

Thanks @trbromley - it looks like there are some test failures that I don't think are related to this PR - in the details I'm seeing errors thrown by tests related to Catalyst and default_qubit. Have you encountered these before?

@trbromley trbromley merged commit 4823273 into PennyLaneAI:master Jan 29, 2024
35 checks passed
@Gabriel-Bottrill Gabriel-Bottrill deleted the qutrit_mixed_apply_operation branch June 5, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants