-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qutrit mixed apply operation #5032
Qutrit mixed apply operation #5032
Conversation
…nylane_qutrit_mixed into qutrit_mixed_initialization
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates so far! Just finished reviewing, and added some comments for the test files.
tests/devices/qutrit_mixed/test_qutrit_mixed_apply_operation.py
Outdated
Show resolved
Hide resolved
tests/devices/qutrit_mixed/test_qutrit_mixed_apply_operation.py
Outdated
Show resolved
Hide resolved
tests/devices/qutrit_mixed/test_qutrit_mixed_apply_operation.py
Outdated
Show resolved
Hide resolved
tests/devices/qutrit_mixed/test_qutrit_mixed_apply_operation.py
Outdated
Show resolved
Hide resolved
tests/devices/qutrit_mixed/test_qutrit_mixed_apply_operation.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making all the changes! This is good to go from my end, just the one documentation update to make.
tests/devices/qutrit_mixed/test_qutrit_mixed_apply_operation.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Reminder to resolve pending comments. Nice work @Gabriel-Bottrill
tests/devices/qutrit_mixed/test_qutrit_mixed_apply_operation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@albi3ro, I had to use your suggestion to input |
@Gabriel-Bottrill, we're good to go to merge this! Would you mind updating your branch as it's a blocker for merging. |
Thanks @trbromley - it looks like there are some test failures that I don't think are related to this PR - in the details I'm seeing errors thrown by tests related to Catalyst and |
Context:
Currently the qutrit_mixed device is being developed this is a necessary addition to the overall project as this applies operations to a qutrit mixed state. This is a prerequisite for other functionality relating to the qutrit mixed device for noisy qutrit simulation.
Description of the Change:
Added functionality for applying operations to a qutrit mixed-state. The new
apply_operation
function can be used to apply gates and Channels to a qutrit mixed-state.Benefits:
Allows for Channels and operations to be applied to a mixed state, will be used to add execute functionality to qutrit mixed-state device allowing for noisy qutrit simulation
Possible Drawbacks:
Abstracting for qubits and more generally qutrits may have added challenges and will require a reforctor or copied code code-smell.
Related GitHub Issues:
N/A