remove support for transform arguments without partial in decorators #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmysilv
commented
Jan 11, 2024
timmysilv
commented
Jan 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5046 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 394 394
Lines 35670 35396 -274
==========================================
- Hits 35554 35279 -275
- Misses 116 117 +1 ☔ View full report in Codecov by Sentry. |
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
…5046) **Context:** We used to advise users to pass transforms additional arguments positionally in transforms being used as decorators. Now, it's forbidden (they need to use `functools.partial`). It has been deprecated for 2 releases, so it's time to remove it. **Description of the Change:** Raise a `TransformError` if someone uses the old transform decorator syntax **Benefits:** Less support for old style of doing things, helps us keep our code cleaner **Possible Drawbacks:** It felt intuitive for me to turn the warning into an explicit error, but usually we just remove code outright when doing removals. This constructor doesn't have an intuitive way of just removing this functionality, so I feel like raises an error explicitly makes sense [sc-51278]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We used to advise users to pass transforms additional arguments positionally in transforms being used as decorators. Now, it's forbidden (they need to use
functools.partial). It has been deprecated for 2 releases, so it's time to remove it.Description of the Change:
Raise a
TransformErrorif someone uses the old transform decorator syntaxBenefits:
Less support for old style of doing things, helps us keep our code cleaner
Possible Drawbacks:
It felt intuitive for me to turn the warning into an explicit error, but usually we just remove code outright when doing removals. This constructor doesn't have an intuitive way of just removing this functionality, so I feel like raises an error explicitly makes sense
[sc-51278]