Deprecate various unused pauli utils #5057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmysilv
commented
Jan 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5057 +/- ##
==========================================
- Coverage 99.67% 99.65% -0.02%
==========================================
Files 394 394
Lines 35670 35395 -275
==========================================
- Hits 35554 35274 -280
- Misses 116 121 +5 ☔ View full report in Codecov by Sentry. |
mudit2812
reviewed
Jan 15, 2024
|
This is great! |
# Conflicts: # doc/development/deprecations.rst # doc/releases/changelog-dev.md
mudit2812
approved these changes
Jan 15, 2024
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
**Context:** Much of the `pauli` module has been sitting stale, and is now being deprecated. **Description of the Change:** - Deprecated `pauli_mult_with_phase`, `pauli_mult`, `_pauli_mult`, `_binary_matrix` and `_get_pauli_map` from the `pauli` module - Fixed some places that are still using `ps1 * ps2` instead of `ps1 @ ps2`. They don't seem to be caught by tests because they are used at test collection time, and pytest only catches ones at test run-time **Benefits:** cleaning up pennylane! [sc-38632]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Much of the
paulimodule has been sitting stale, and is now being deprecated.Description of the Change:
pauli_mult_with_phase,pauli_mult,_pauli_mult,_binary_matrixand_get_pauli_mapfrom thepaulimoduleps1 * ps2instead ofps1 @ ps2. They don't seem to be caught by tests because they are used at test collection time, and pytest only catches ones at test run-timeBenefits:
cleaning up pennylane!
[sc-38632]