-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove QuantumScript.is_sampled and QuantumScript.all_sampled #5072
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5072 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 394 394
Lines 35670 35460 -210
==========================================
- Hits 35554 35344 -210
Misses 116 116 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+17 −60
love it
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Complete deprecation cycle and remove `QuantumScript.is_sampled` and `QuantumScript.all_sampled`. [sc-51276] --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai> Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Complete deprecation cycle and remove
QuantumScript.is_sampled
andQuantumScript.all_sampled
.[sc-51276]