Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QuantumScript.is_sampled and QuantumScript.all_sampled #5072

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

Alex-Preciado
Copy link
Contributor

@Alex-Preciado Alex-Preciado commented Jan 16, 2024

Complete deprecation cycle and remove QuantumScript.is_sampled and QuantumScript.all_sampled.

[sc-51276]

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c01cb4b) 99.67% compared to head (82022d7) 99.67%.
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5072      +/-   ##
==========================================
- Coverage   99.67%   99.67%   -0.01%     
==========================================
  Files         394      394              
  Lines       35670    35460     -210     
==========================================
- Hits        35554    35344     -210     
  Misses        116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

doc/development/deprecations.rst Outdated Show resolved Hide resolved
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+17 −60

love it :shipit:

@Alex-Preciado Alex-Preciado merged commit 89ba423 into master Jan 17, 2024
35 checks passed
@Alex-Preciado Alex-Preciado deleted the remove-qscript-sampled-properties branch January 17, 2024 17:22
mudit2812 added a commit that referenced this pull request Jan 19, 2024
Complete deprecation cycle and remove `QuantumScript.is_sampled` and
`QuantumScript.all_sampled`.

[sc-51276]

---------

Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants