Fix TrotterProduct fail for a Hamiltonian with identical coefficients #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
soranjh
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5073 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 394 394
Lines 36073 35806 -267
==========================================
- Hits 35962 35694 -268
- Misses 111 112 +1 ☔ View full report in Codecov by Sentry. |
1 task
KetpuntoG
approved these changes
Jan 26, 2024
|
[sc-54033] |
Jaybsoni
reviewed
Jan 31, 2024
Jaybsoni
requested changes
Jan 31, 2024
albi3ro
added a commit
that referenced
this pull request
Feb 12, 2024
) [sc-55330] See also PR #5073 and Issue #5066 . Sometimes `qml.dot` was returning a scalar product between a single coefficient and a sum, instead of returning a sum. `TrotterProduct` was not able to handle this sort of nested operator. While we should also make our code more flexible in handling nested operators, we can also standardize the return of `qml.dot`.
Gabriel-Bottrill
pushed a commit
to QSAR-UBC/pennylane_qutrit_mixed
that referenced
this pull request
Feb 14, 2024
…nnyLaneAI#5143) [sc-55330] See also PR PennyLaneAI#5073 and Issue PennyLaneAI#5066 . Sometimes `qml.dot` was returning a scalar product between a single coefficient and a sum, instead of returning a sum. `TrotterProduct` was not able to handle this sort of nested operator. While we should also make our code more flexible in handling nested operators, we can also standardize the return of `qml.dot`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Fixes this bug. The input hamiltonian in
TrotterProductis internally converted to aSum. But a Hamiltonian with identical coefficients (=! 1) created internally withqml.dot(coeffs, ops)has typeSProdand gives an error.Description of the Change:
The following addition to
TrotterProductfixes the issue:Benefits:
Possible Drawbacks:
Related GitHub Issues: