fix undo_swaps and split_non_commuting
#5081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Jan 18, 2024
albi3ro
commented
Jan 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5081 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 394 394
Lines 35733 35452 -281
==========================================
- Hits 35622 35340 -282
- Misses 111 112 +1 ☔ View full report in Codecov by Sentry. |
trbromley
reviewed
Jan 19, 2024
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
When exploring in PR #5058, I found bugs in `undo_swaps` and `split_non_commuting`. [sc-54373] [sc-54374] Undo swaps had a fragile way of mapping wires, as it was created before we had `Operator.map_wires`. Now it works with more general operations. `split_non_commuting` was not passing the shots along. This was a silent issue on the old device interface, but would be causing problems if it was ever used with the new device interface. --------- Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exploring in PR #5058, I found bugs in
undo_swapsandsplit_non_commuting.[sc-54373]
[sc-54374]
Undo swaps had a fragile way of mapping wires, as it was created before we had
Operator.map_wires. Now it works with more general operations.split_non_commutingwas not passing the shots along. This was a silent issue on the old device interface, but would be causing problems if it was ever used with the new device interface.