fail CI if coverage fails to upload #5101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When the Codecov upload action fails because of network issues or the like, the action reports as passed, then the
codecov
action stays as "Expected" forevermore. This is worse than a failure because it continues to block us but we don't immediately know why. If we knew, we could just re-run it when we find out.Description of the Change:
Set the codecov upload action to fail on failure 😄
Benefits:
We will know when it fails to upload, and we can re-run the upload task manually
Possible Drawbacks:
External contributors might hit this, and although the old ways were also bad, this might be a bit more visibly frightening if you don't know why you got a big red ❌