-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abstract AlgorithmicError
class
#5115
Conversation
Hello. You may have forgotten to update the changelog!
|
[sc-55439] |
[sc-55154] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5115 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 394 395 +1
Lines 36075 35815 -260
==========================================
- Hits 35964 35703 -261
- Misses 111 112 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5115 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 395 396 +1
Lines 36455 36191 -264
==========================================
- Hits 36341 36076 -265
- Misses 114 115 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing more to add. Thank you for that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think I convinced myself that AlgorithmicError
works as the name.
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
**Context:** The first of a few PRs adding error propagation functionality to PennyLane **Description of the Change:** Add abstract `AlgorithmicError` class --------- Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com> Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
Context:
The first of a few PRs adding error propagation functionality to PennyLane
Description of the Change:
Add abstract
AlgorithmicError
class