-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert special handling of PhaseShift in ctrl #5148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast turnaround 🎉
I think that adding the backslash to the link should pacify sphinx, but if not we can just remove the duplicate link.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5148 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 394 394
Lines 36075 35801 -274
==========================================
- Hits 35964 35689 -275
- Misses 111 112 +1 ☔ View full report in Codecov by Sentry. |
What do we currently do in the case where there is a single control wire on the |
Yes we do. |
Context:
Multi-wire controlled
PhaseShift
should not be converted to a one-less-wire controlledControlledPhaseShift
Description of the Change:
qml.ctrl
no longer convert multi-wire controlledPhaseShift
to a one-less-wire controlledControlledPhaseShift
PhaseShift
in decompositionsBenefits:
PhaseShift