-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: ctrl_decomp_zyz - isclose => allclose #5198
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5198 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 396 396
Lines 36661 36378 -283
==========================================
- Hits 36547 36262 -285
- Misses 114 116 +2 ☔ View full report in Codecov by Sentry. |
Rot decomposition isclose allclose [sc-56743] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding some tests?
No, some functional test like the example above would be good? |
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@albi3ro I limited the changes to |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint
, and thenrun
pylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
While introducing
C(Rot)
in Lightning, the test below failed inctrl_decomp_zyz
because all theqml.math.isclose
branches raise errors with gradient tracers.Description of the Change:
Change
isclose
byallclose
as suggested by @albi3ro .Benefits:
Possible Drawbacks:
Related GitHub Issues: