fix qubitdensitymatrix on default.mixed #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmysilv
commented
Feb 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5203 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 396 396
Lines 36638 36366 -272
==========================================
- Hits 36524 36251 -273
- Misses 114 115 +1 ☔ View full report in Codecov by Sentry. |
albi3ro
approved these changes
Feb 14, 2024
mudit2812
approved these changes
Feb 15, 2024
# Conflicts: # doc/releases/changelog-dev.md
timmysilv
added a commit
that referenced
this pull request
Feb 26, 2024
Mandrenkov
added a commit
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Jax-jit (or any tracing tool) does not allow reading/depending on the concrete value of a tracer.
default.mixedcurrently validates the trace of the parameter passed toQubitDensityMatrixbefore applying it.Description of the Change:
If the parameter is abstract, do not validate it
Benefits:
default.mixedcan now useQubitDensityMatrixwith jax-jitPossible Drawbacks:
It will now try to apply invalid density matrices because it cannot check it. This (skipping validation of concrete values while tracing) is common practice in PennyLane, so it should be ok.
Related GitHub Issues:
Fixes #5196