Clear error message if plugin is not installed #5218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5218 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 396 396
Lines 36656 36389 -267
==========================================
- Hits 36542 36274 -268
- Misses 114 115 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
lillian542
commented
Feb 15, 2024
|
[sc-56069] |
obliviateandsurrender
approved these changes
Feb 15, 2024
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
…ne into install_plugin_error
Mandrenkov
pushed a commit
that referenced
this pull request
Feb 16, 2024
**Context:** Currently if you try to use `qml.from_qiskit` without the plugin installed, you get the somewhat non-specific `ValueError: Converter does not exist. Make sure the required plugin is installed and supports conversion.` **Description of the Change:** If the "converter does not exist" error is raised when calling `qml.from_qiskit`, the user is shown a more explicit message with instructions for installing the plugin and for contacting the forum if they have issues. --------- Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently if you try to use
qml.from_qiskitwithout the plugin installed, you get the somewhat non-specificValueError: Converter does not exist. Make sure the required plugin is installed and supports conversion.Description of the Change:
If the "converter does not exist" error is raised when calling
qml.from_qiskit, the user is shown a more explicit message with instructions for installing the plugin and for contacting the forum if they have issues.