-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quick start page for importing workflows #5281
Add quick start page for importing workflows #5281
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.35.0-rc0 #5281 +/- ##
==============================================
Coverage ? 99.65%
==============================================
Files ? 399
Lines ? 36622
Branches ? 0
==============================================
Hits ? 36494
Misses ? 128
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Importing Circuits
quick start page
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, Mikhail! 🚀
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions, and one correction to the QASM circuit.
Maybe we should include an example showing that the Qiskit circuits can be differentiable? But maybe that's overkill for a quick start and they should check the qml.from_qiskit
docs.
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
Thanks for taking another look, @lillian542!
I discussed this with @trbromley offline and we agreed that although this would be nice it is not particularly urgent and can wait until the v0.36.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments, but approved otherwise
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready to go, thanks @Mandrenkov! 🎉
Context:
Currently, PennyLane is lacking a quick start page which explains how to import circuits defined in other frameworks into PennyLane. This could highlight some of the recent additions made to the
io
module.Description of the Change:
Added an "Importing worklows" quick start page. This includes examples of importing circuits from:
An additional section is included for importing Qiskit
SparsePauliOp
instances.Benefits:
Possible Drawbacks:
None.
Related GitHub Issues:
None.