-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove using * for matrix and tensor products of PauliWord and PauliSentence #5341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astralcai
changed the title
Remove regular multiplication for PauliWords and PauliSentences
Remove using * for matrix and tensor products of PauliWord and PauliSentence
Mar 7, 2024
Remove more non-applicable tests
lillian542
reviewed
Mar 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5341 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 401 401
Lines 37294 36925 -369
==========================================
- Hits 37160 36791 -369
Misses 134 134 ☔ View full report in Codecov by Sentry. |
albi3ro
approved these changes
Mar 8, 2024
lillian542
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Complete the deprecation cycle for using * for matrix and tensor products of
PauliWord
andPauliSentence
Description of the Change:
Using * for matrix and tensor products of
PauliWord
andPauliSentence
will now raise an error.Related Shortcut Issues:
[sc-58304]