Pauli sentence bug #5407
Merged
Pauli sentence bug #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Tarun-Kumar07 for this! I've tagged some reviewers who will take a look soon. |
|
Just for our internal tracking: [sc-58518] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5407 +/- ##
==========================================
+ Coverage 99.63% 99.65% +0.01%
==========================================
Files 399 401 +2
Lines 37125 36950 -175
==========================================
- Hits 36990 36821 -169
+ Misses 135 129 -6 ☔ View full report in Codecov by Sentry. |
Qottmann
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
This is great, thanks @Tarun-Kumar07
Nothing to complain, looks good right off the bat 👌
albi3ro
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Earlier
PauliSentence.to_mat(wire_order)failed with exception when it hadonly empty PauliWords.This has been fixed under this PR.
Description of the Change:
Earlier when
PauliWorddidn't have wires the function_pw_wiresdefaulted toPauliSentencewires. Now rather thanPauliSentenceitself, it defaults towire_orderBenefits:
Possible Drawbacks:
Related GitHub Issues:
Fixes #5354