-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix qutrit mixed sampling of hamiltonians #5413
Conversation
Hello. You may have forgotten to update the changelog!
|
…into qutrit-sampling
…into qutrit-sampling
@@ -29,7 +29,7 @@ | |||
from pennylane.measurements import Shots | |||
|
|||
|
|||
APPROX_ATOL = 0.01 | |||
APPROX_ATOL = 0.05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably I'm missing something, but I thought that this wasn't necessary anymore after this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to fix intermittent failures due to random fluctuations, actually unrelated to the actual failing test cases that this PR addresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then it is the same issues that affected other PRs as well with opmath enabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ham-tests #5413 +/- ##
==========================================
Coverage 99.46% 99.46%
==========================================
Files 400 400
Lines 37133 37133
==========================================
Hits 36935 36935
Misses 198 198 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Context:
TestHamiltonianSamples
fails in ham-testsDescription of the Change:
Update
qml.Hamiltonian
toqml.ops.Hamiltonian
inisinstance
checks such that it always refer to the oldHamiltonian
[sc-59163]