Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when applying Snapshot with measurements on default.mixed #5416

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

astralcai
Copy link
Contributor

Context:
default.mixed device does not support Snapshot with measurements. It returns the density matrix, which is incorrect.

Description of the Change:
Adds an error message to when Snapshot with measurements is used on default.mixed.

Benefits:
Less confusion.

Possible Drawbacks:
New error raised. This is a near-term fix until we improve default.mixed to properly support Snapshot

Related GitHub Issues:
#5202
[sc-56793]

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (186faaf) to head (733908d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5416      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files         399      399              
  Lines       37112    36830     -282     
==========================================
- Hits        36977    36694     -283     
- Misses        135      136       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @astralcai!

@astralcai astralcai marked this pull request as ready for review March 20, 2024 20:21
@astralcai astralcai requested a review from albi3ro March 20, 2024 20:21
@astralcai astralcai enabled auto-merge (squash) March 20, 2024 21:54
@astralcai astralcai merged commit d6cef4f into master Mar 20, 2024
40 checks passed
@astralcai astralcai deleted the mixed-snapshot branch March 20, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants