-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jit with sampling multi-wire observable #5422
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5422 +/- ##
==========================================
+ Coverage 99.63% 99.65% +0.01%
==========================================
Files 399 401 +2
Lines 37125 36946 -179
==========================================
- Hits 36990 36817 -173
+ Misses 135 129 -6 ☔ View full report in Codecov by Sentry. |
I'm not sure if I understand the issue. Why would the shape always be 1? |
Because with an observable, we are sampling from the observables eigenvalues. So just one single eigenvalue, even if there's multiple wires. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🐱
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one changelog comment.
Context:
Jitting was failing with
qml.sample
with an observable on more than one wire.Description of the Change:
Update
SampleMP.shape
so that if there's an observable, there's only one dimension output.Benefits:
Possible Drawbacks:
Related GitHub Issues:
Fixes #5372 [sc-58779]