Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of qml.Hamiltonian from hamiltonian.py #5429

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

astralcai
Copy link
Contributor

hamiltonian.py defines the legacy Hamiltonian. It should not be returning LinearCombination in its own methods even with new op math enabled.

@astralcai astralcai requested a review from Qottmann March 21, 2024 19:31
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@astralcai
Copy link
Contributor Author

[sc-59501]

@astralcai astralcai marked this pull request as ready for review March 21, 2024 19:50
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (5013e4b) to head (a18552f).
Report is 12 commits behind head on ham-tests.

Additional details and impacted files
@@            Coverage Diff             @@
##           ham-tests    #5429   +/-   ##
==========================================
  Coverage      99.48%   99.48%           
==========================================
  Files            400      400           
  Lines          37146    37146           
==========================================
  Hits           36954    36954           
  Misses           192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 self-requested a review March 22, 2024 16:27
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Qottmann Qottmann added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Mar 22, 2024
@Qottmann
Copy link
Contributor

same for this, wait for ham-tests CI to pass before merging

@lillian542 lillian542 added this to the enable_new_opmath milestone Mar 22, 2024
@Qottmann Qottmann merged commit 0558038 into ham-tests Mar 25, 2024
30 of 35 checks passed
@Qottmann Qottmann deleted the hams branch March 25, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-ready ✔️ All tests pass and the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants