Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add algorithmic errors tracking to qml.Tracker #5465

Merged
merged 27 commits into from
Apr 12, 2024

Conversation

obliviateandsurrender
Copy link
Contributor

Context: Update qml.Tracker to track and combine error

Description of the Change: Add algorithmic error tracking in the simulator_tracking device modifier.

Benefits: tracker will track algorithmic errors.

Possible Drawbacks: N/A

Related GitHub Issues: N/A

@obliviateandsurrender
Copy link
Contributor Author

[sc-55445]

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (b2b0c36) to head (1930064).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5465      +/-   ##
==========================================
- Coverage   99.67%   99.66%   -0.01%     
==========================================
  Files         404      404              
  Lines       37833    37554     -279     
==========================================
- Hits        37709    37429     -280     
- Misses        124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obliviateandsurrender obliviateandsurrender changed the base branch from master to specs_algo_error April 3, 2024 02:46
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left just one minor suggestion. Also, not sure why preprocess is needed.

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
Base automatically changed from specs_algo_error to master April 12, 2024 19:07
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@obliviateandsurrender obliviateandsurrender merged commit 9b60998 into master Apr 12, 2024
38 checks passed
@obliviateandsurrender obliviateandsurrender deleted the tracker_algo_error branch April 12, 2024 20:00
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants