Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DLA 4] qml.dla.center function #5477

Merged
merged 366 commits into from
Apr 25, 2024
Merged

[DLA 4] qml.dla.center function #5477

merged 366 commits into from
Apr 25, 2024

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Apr 5, 2024 •
edited
Loading

A simple qml.dla.center function

#5161 (DLA1) #5169 (DLA2) #5406 (DLA3) #5477 (DLA4)

Implement center [sc-51435]

Qottmann and others added 30 commits March 4, 2024 11:02
@Qottmann
Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…
cfe8850 
…o lieclosure
@Qottmann
tol test
3edc87a
@Qottmann
Merge branch 'master' into lieclosure
f645da6
@Qottmann
Merge branch 'master' into lieclosure
0f6d4fe
@Qottmann
merge
0eba2bf
@Qottmann
Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…
4838660 
…o lieclosure
@Qottmann
add test for coverage
7b96605
@Qottmann
black formatting
1581a5d
@Qottmann
Merge branch 'lieclosure' of https://github.com/PennyLaneAI/pennylane …
1485118 
…into lieclosure2
@Qottmann
Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…
abb3595 
…o lieclosure
@Qottmann
code review suggestions
6bb9e17
@Qottmann
black formatting
0ad5840
@Qottmann
code review
9d2b19a
@Qottmann
Merge branch 'lieclosure' of https://github.com/PennyLaneAI/pennylane …
eff142d 
…into lieclosure2
@Qottmann
remove re-defined pauli_rep property
44204ba
@Qottmann @vincentmr
Update pennylane/dla/lie_closure.py
b5e40cd 
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
@Qottmann
black formatting
bdbfd6d
@Qottmann
[ci skip]
b8d23b7
@Qottmann
black formatting
6dc2e4b
@Qottmann @dwierichs
Apply suggestions from code review
a7c9bd9 
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
@Qottmann
Merge branch 'master' into lieclosure
056e750
@Qottmann
merge and add example to doc string
be3fe44
@Qottmann
black formatting
b0b6b2e
@Qottmann
adjoint representation
6acb926
@Qottmann
black formatting
4f9b086
@Qottmann
add files
f3cdb7a
@Qottmann
PauliSentence.trace() method
e3fa1f5
@Qottmann
black formatting
def9943
@Qottmann
PauliWord.trace() function pointless
109415c
@Qottmann
Merge branch 'master' into lieclosure
b21006f
Base automatically changed from adjointrepr to master April 23, 2024 08:11
@trbromley trbromley self-requested a review April 23, 2024 12:44
trbromley
trbromley reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Qottmann! This looks great, I've left a few comments but no major blockers from me.

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/pauli/dla/center.py Outdated Show resolved Hide resolved
pennylane/pauli/dla/center.py Outdated Show resolved Hide resolved
pennylane/pauli/dla/center.py Outdated Show resolved Hide resolved
@Qottmann Qottmann enabled auto-merge (squash) April 25, 2024 09:30
@Qottmann Qottmann merged commit cc7fe0a into master Apr 25, 2024
38 checks passed
@Qottmann Qottmann deleted the liecenter branch April 25, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwierichs dwierichs dwierichs approved these changes

@trbromley trbromley trbromley left review comments

@vincentmr vincentmr vincentmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Qottmann @vincentmr @dwierichs @trbromley