Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qml.Qubitization template #5500

Merged
merged 48 commits into from
Apr 25, 2024
Merged

qml.Qubitization template #5500

merged 48 commits into from
Apr 25, 2024

Conversation

KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented Apr 11, 2024 •
edited
Loading

Adding qml.Qubitization operator.

@KetpuntoG
Copy link
Contributor Author

KetpuntoG commented Apr 11, 2024 •
edited by soranjh
Loading

[sc-61135]

@github-actions GitHub Actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov Codecov
Copy link

codecov bot commented Apr 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (9151477) to head (0551996).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5500      +/-   ##
==========================================
- Coverage   99.69%   99.69%   -0.01%     
==========================================
  Files         410      412       +2     
  Lines       38278    38147     -131     
==========================================
- Hits        38161    38029     -132     
- Misses        117      118       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

trbromley
trbromley reviewed Apr 12, 2024
View reviewed changes
patata.py Outdated Show resolved Hide resolved
@Jaybsoni Jaybsoni self-requested a review April 18, 2024 18:18
soranjh
soranjh reviewed Apr 24, 2024
View reviewed changes
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
tests/templates/test_subroutines/test_qubitization.py Outdated Show resolved Hide resolved
tests/templates/test_subroutines/test_qubitization.py Outdated Show resolved Hide resolved
tests/templates/test_subroutines/test_qubitization.py Outdated Show resolved Hide resolved
albi3ro
albi3ro reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a test running an instance through qml.ops.functions.assert_valid?

@trbromley trbromley added this to the v0.36 milestone Apr 25, 2024
DSGuala
DSGuala reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review: looks good to me in general. I left some suggestions on minor changes to the docs.

Will try to take another look and test it before the feature freeze. But no blockers from my end.

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Show resolved Hide resolved
pennylane/templates/subroutines/qubitization.py Outdated Show resolved Hide resolved
KetpuntoG and others added 4 commits April 25, 2024 13:52
@KetpuntoG @DSGuala @soranjh
Apply suggestions from code review
47151b2 
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
@KetpuntoG
final comments
ac24c7b
@KetpuntoG
Merge branch 'qubitization' of https://github.com/PennyLaneAI/pennylane…
7c52067 
… into qubitization
@KetpuntoG
Merge branch 'master' into qubitization
107fa7e
@KetpuntoG KetpuntoG requested a review from soranjh April 25, 2024 19:13
soranjh
soranjh approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

pennylane/templates/subroutines/qubitization.py Outdated Show resolved Hide resolved
Jaybsoni
Jaybsoni approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this one! Happy to approve, just a few questions to clarify!

tests/templates/test_subroutines/test_qubitization.py Show resolved Hide resolved
tests/templates/test_subroutines/test_qubitization.py Show resolved Hide resolved
@KetpuntoG KetpuntoG added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Apr 25, 2024
@astralcai astralcai enabled auto-merge (squash) April 25, 2024 20:57
@astralcai astralcai merged commit f513b7f into master Apr 25, 2024
38 checks passed
@astralcai astralcai deleted the qubitization branch April 25, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSGuala DSGuala DSGuala left review comments

@trbromley trbromley trbromley left review comments

@albi3ro albi3ro albi3ro left review comments

@soranjh soranjh soranjh approved these changes

@Jaybsoni Jaybsoni Jaybsoni approved these changes

Assignees
No one assigned
Labels
merge-ready ✔️ All tests pass and the PR is ready to be merged.
Projects
None yet
Milestone
v0.36
Development

Successfully merging this pull request may close these issues.
7 participants
@KetpuntoG @albi3ro @Jaybsoni @soranjh @trbromley @DSGuala @astralcai