Operations/measurements on all wires are drawn correctly with mid-circuit measurements #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mudit2812
commented
Apr 11, 2024
|
[sc-61127] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5501 +/- ##
==========================================
- Coverage 99.66% 99.66% -0.01%
==========================================
Files 402 404 +2
Lines 37635 37540 -95
==========================================
- Hits 37510 37415 -95
Misses 125 125 ☔ View full report in Codecov by Sentry. |
dwierichs
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Nice, thanks for the quick fix @mudit2812
And nice that you caught the analogous measurement problem, too!
Only have one weak suggestion
albi3ro
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Bug fix for #5499
Description of the Change:
Adding labels to layer strings only extends to wires, not classical bits.
Benefits:
Drawer works correctly with mid-circuit measurements
Possible Drawbacks:
Related GitHub Issues: