-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new opmath] Deprecation warnings and making LinearCombination.compare
more user friendly
#5504
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5504 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 410 410
Lines 38247 37944 -303
==========================================
- Hits 38130 37826 -304
- Misses 117 118 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Qottmann!
LinearCombination.compare
more user friendlyLinearCombination.compare
more user friendly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a small comment.
…o newopmathdeprecations
Removing
LinearCombination._obs_data
, which requires updatingLinearCombination.compare
. While at it, also updating the doc string to make it clear.Potential Drawbacks
A comparison with an
Observable
that has no pauli_rep (i.e. involving aHadamard
) will not work due to https://github.com/PennyLaneAI/pennylane/blob/master/pennylane/ops/functions/equal.py#L160. I consider this a separate issue for updating qml.equal accordingly. Alternative solution is to giveHadamard
apauli_rep
.[sc-59339]