Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving support of counts and sample with default.mixed #5514

Merged
merged 9 commits into from
Apr 19, 2024

Conversation

obliviateandsurrender
Copy link
Contributor

Context: Counts should work with interfaces (torch, tf, jax) and default.mixed but it is not the case. This PR fixes it.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues: #2984

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@obliviateandsurrender
Copy link
Contributor Author

[sc-25027]

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (016d2cc) to head (0f47690).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5514      +/-   ##
==========================================
- Coverage   99.67%   99.66%   -0.01%     
==========================================
  Files         406      406              
  Lines       37928    37643     -285     
==========================================
- Hits        37804    37518     -286     
- Misses        124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obliviateandsurrender obliviateandsurrender changed the title Supporting counts with default.mixed Improving support of counts and sample with default.mixed Apr 15, 2024
@obliviateandsurrender obliviateandsurrender requested review from a team and Jaybsoni April 15, 2024 20:36
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼,

This might also natively support jax now. If that's the case it would be nice to also add jax tests. Not blocking though.

Edit:

I realized afterwards that this fix is for the torch default mixed device. Looks good 👍🏼

@obliviateandsurrender obliviateandsurrender merged commit 313de85 into master Apr 19, 2024
38 checks passed
@obliviateandsurrender obliviateandsurrender deleted the mixed_counts branch April 19, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants