-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving support of counts
and sample
with default.mixed
#5514
Conversation
Hello. You may have forgotten to update the changelog!
|
[sc-25027] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5514 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 406 406
Lines 37928 37643 -285
==========================================
- Hits 37804 37518 -286
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
counts
with default.mixed
counts
and sample
with default.mixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏼,
This might also natively support jax now. If that's the case it would be nice to also add jax tests. Not blocking though.
Edit:
I realized afterwards that this fix is for the torch default mixed device. Looks good 👍🏼
Context:
Counts
should work with interfaces (torch, tf, jax) anddefault.mixed
but it is not the case. This PR fixes it.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: #2984