-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Make qml.equal
work with qml.HilbertSchmidt
#5538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5538 +/- ##
========================================
Coverage 99.67% 99.67%
========================================
Files 407 407
Lines 38019 37750 -269
========================================
- Hits 37895 37628 -267
+ Misses 124 122 -2 ☔ View full report in Codecov by Sentry. |
dwierichs
commented
Apr 22, 2024
albi3ro
approved these changes
Apr 22, 2024
astralcai
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
qml.HilbertSchmidt
hasQuantumScript
instances as hyperparameters, which are not compared correctly by the defaultOperator
dispatch ofqml.equal
.Description of the Change:
This PR adds a custom dispatch branch for
qml.HilbertSchmidt
toqml.equal
, comparing theQuantumScript
hyperparameters with additionalqml.equal
calls.Benefits:
bug fix
Possible Drawbacks:
Related GitHub Issues:
fixes #5536
[sc-61589]
[sc-49174]