equal with sum and product of no wires op #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Apr 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5562 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 410 410
Lines 38235 37951 -284
==========================================
- Hits 38118 37833 -285
- Misses 117 118 +1 ☔ View full report in Codecov by Sentry. |
Qottmann
reviewed
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Operators that don't have any wires (
GlobalPhaseandIdentity) are newer additions that don't have full feature coverage in all places. This can lead to some logic that is unable to handle them.Description of the Change:
Allows
Sum._sortandProd._sortto work with operators that don't have any wires.Benefits:
Possible Drawbacks:
Related GitHub Issues:
Fixes #5498 [sc-61115]