-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Null qubit supports any operation without a decomposition #5582
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this with qml.QuantumPhaseEstimation
, qml.TrotterProduct
, the code from issue #5508, the qml.resource documentation example, and the error estimation demo draft.
Looks like it's working as intended. Defining a decomposition for an ErrorOperation
destroys the error information in qml.Tracker
. But that's according to plan. We can decide how to address this in the next release and users who want to define decompositions for error ops can use default.qubit
in the meantime.
👍 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5582 +/- ##
==========================================
- Coverage 99.69% 99.69% -0.01%
==========================================
Files 410 412 +2
Lines 38278 38237 -41
==========================================
- Hits 38161 38119 -42
- Misses 117 118 +1 ☔ View full report in Codecov by Sentry. |
Context:
Description of the Change:
null.qubit will now automatically support any operation that doesn't have a decomposition.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-61258] Fixes #5508