Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/mcm key dtype #5587

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Bugfix/mcm key dtype #5587

merged 8 commits into from
Apr 30, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Apr 29, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
qml.counts does not return the same keys with dynamic_one_shot and defer_measurements.

Description of the Change:
Cast keys to the type produced by concretize.

Benefits:
Consistent keys.

Possible Drawbacks:
Slight (likely unnoticeable) performance decrease since NDArray object cannot be preallocated.

Related GitHub Issues:
#5566

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @vincentmr
Could you add a test for the fix, maybe just the case from the issue? :)

pennylane/transforms/dynamic_one_shot.py Outdated Show resolved Hide resolved
pennylane/transforms/dynamic_one_shot.py Show resolved Hide resolved
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v0.36.0-rc0@b3c263f). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.36.0-rc0    #5587   +/-   ##
==============================================
  Coverage               ?   99.69%           
==============================================
  Files                  ?      412           
  Lines                  ?    38280           
  Branches               ?        0           
==============================================
  Hits                   ?    38162           
  Misses                 ?      118           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vincentmr and others added 2 commits April 29, 2024 11:29
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
@vincentmr vincentmr marked this pull request as ready for review April 29, 2024 15:30
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentmr !

@vincentmr vincentmr requested a review from a team April 29, 2024 17:31
@mudit2812 mudit2812 added this to the v0.36 milestone Apr 29, 2024
@vincentmr vincentmr enabled auto-merge (squash) April 29, 2024 18:33
@vincentmr vincentmr merged commit d95390f into v0.36.0-rc0 Apr 30, 2024
37 checks passed
@vincentmr vincentmr deleted the bugfix/mcm_key_dtype branch April 30, 2024 13:15
@vincentmr
Copy link
Contributor Author

[sc-61845]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants