-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/mcm key dtype #5587
Bugfix/mcm key dtype #5587
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix, @vincentmr
Could you add a test for the fix, maybe just the case from the issue? :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.36.0-rc0 #5587 +/- ##
==============================================
Coverage ? 99.69%
==============================================
Files ? 412
Lines ? 38280
Branches ? 0
==============================================
Hits ? 38162
Misses ? 118
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vincentmr !
[sc-61845] |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint
, and thenrun
pylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
qml.counts
does not return the samekeys
withdynamic_one_shot
anddefer_measurements
.Description of the Change:
Cast
keys
to the type produced byconcretize
.Benefits:
Consistent
keys
.Possible Drawbacks:
Slight (likely unnoticeable) performance decrease since
NDArray
object cannot be preallocated.Related GitHub Issues:
#5566