-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update qcut
docs. Remove id
from label of qcut.MeasureNode
and qcut.PrepareNode
#5613
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.36.0-rc0 #5613 +/- ##
==============================================
Coverage ? 99.69%
==============================================
Files ? 412
Lines ? 38334
Branches ? 0
==============================================
Hits ? 38216
Misses ? 118
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dwierichs!
Context:
MeasureNode
andPrepareNode
automatically have a UUID (#2224), which is being printed in tape text (#4749)Description of the Change:
Update the docs of the
qcut
module to reflect some minor changes ,mostly in formatting/tape printing default settings.Update the
label
method ofMeasureNode
andPrepareNode
to not include theirid
.Benefits:
Updated docs.
Nicely printing qcut tape texts
Possible Drawbacks:
Related GitHub Issues: