-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error on setting shots on new device api #5616
Conversation
Hello. You may have forgotten to update the changelog!
|
[sc-62372] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.36.0-rc0 #5616 +/- ##
==============================================
Coverage ? 99.69%
==============================================
Files ? 412
Lines ? 38312
Branches ? 0
==============================================
Hits ? 38194
Misses ? 118
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @albi3ro!
Context:
As more devices switch to the new device interface, users may request properties or behaviours that are no longer there. The current error messages do not sufficiently alert users to the fact that the device interface has changed.
Description of the Change:
Make a more informative error when trying to set the shots or access a non-existant attribute.
Benefits:
Possible Drawbacks:
Related GitHub Issues: