Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix param_shift(..., broadcast=True) with zero-length gradient recipes #5623

Merged
merged 7 commits into from
May 3, 2024

Conversation

dwierichs
Copy link
Contributor

@dwierichs dwierichs commented May 2, 2024

Context:

Description of the Change:
Introduces a special branch for the rare case of zero-length parameter-shift recipes.

Benefits:
Fixes #5622

Possible Drawbacks:

Related GitHub Issues:
Fixes #5622

[sc-62416]

Copy link
Contributor

github-actions bot commented May 2, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v0.36.0-rc0@1798b1f). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.36.0-rc0    #5623   +/-   ##
==============================================
  Coverage               ?   99.69%           
==============================================
  Files                  ?      412           
  Lines                  ?    38336           
  Branches               ?        0           
==============================================
  Hits                   ?    38218           
  Misses                 ?      118           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudit2812 mudit2812 added this to the v0.36 milestone May 2, 2024
@lillian542 lillian542 self-requested a review May 2, 2024 18:45
@dwierichs dwierichs added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label May 3, 2024
@dwierichs dwierichs enabled auto-merge (squash) May 3, 2024 09:22
@dwierichs dwierichs merged commit be9f86a into v0.36.0-rc0 May 3, 2024
37 checks passed
@dwierichs dwierichs deleted the parshift-broadcast-custom branch May 3, 2024 09:48
@dwierichs dwierichs removed the merge-ready ✔️ All tests pass and the PR is ready to be merged. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants