-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix param_shift(..., broadcast=True)
with zero-length gradient recipes
#5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. You may have forgotten to update the changelog!
|
dwierichs
commented
May 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.36.0-rc0 #5623 +/- ##
==============================================
Coverage ? 99.69%
==============================================
Files ? 412
Lines ? 38336
Branches ? 0
==============================================
Hits ? 38218
Misses ? 118
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dwierichs
commented
May 2, 2024
dwierichs
commented
May 2, 2024
dwierichs
commented
May 2, 2024
astralcai
approved these changes
May 2, 2024
mudit2812
approved these changes
May 2, 2024
lillian542
approved these changes
May 2, 2024
dwierichs
added
the
merge-ready ✔️
All tests pass and the PR is ready to be merged.
label
May 3, 2024
dwierichs
removed
the
merge-ready ✔️
All tests pass and the PR is ready to be merged.
label
May 3, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Description of the Change:
Introduces a special branch for the rare case of zero-length parameter-shift recipes.
Benefits:
Fixes #5622
Possible Drawbacks:
Related GitHub Issues:
Fixes #5622
[sc-62416]