Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning qubit uses parameter shift if metric tensor applied #5624

Merged
merged 16 commits into from
May 3, 2024

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented May 2, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@astralcai astralcai added this to the v0.36 milestone May 2, 2024
tests/gradients/core/test_metric_tensor.py Outdated Show resolved Hide resolved
pennylane/gradients/metric_tensor.py Show resolved Hide resolved
doc/releases/changelog-0.36.0.md Show resolved Hide resolved
@albi3ro albi3ro requested a review from dwierichs May 3, 2024 15:22
@albi3ro
Copy link
Contributor Author

albi3ro commented May 3, 2024

See issue #5642

@albi3ro albi3ro requested a review from a team May 3, 2024 18:14
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v0.36.0-rc0@76edb60). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.36.0-rc0    #5624   +/-   ##
==============================================
  Coverage               ?   99.69%           
==============================================
  Files                  ?      412           
  Lines                  ?    38328           
  Branches               ?        0           
==============================================
  Hits                   ?    38210           
  Misses                 ?      118           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro albi3ro merged commit f964d44 into v0.36.0-rc0 May 3, 2024
37 checks passed
@albi3ro albi3ro deleted the transform-program-fix branch May 3, 2024 19:39
@trbromley
Copy link
Contributor

Thanks @albi3ro! So I understand, this PR does not resolve the issue reported in #5642 but is just related, right?

@albi3ro
Copy link
Contributor Author

albi3ro commented May 6, 2024

When writing tests for this PR, I found #5642. Because I didn't have time to fix it, I marked some jax tests as xfail and opened a bug report.

So this PR uncovered but did not fix #5642 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants