Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename values for method kwarg in TrotterProduct class #5637

Merged
merged 2 commits into from
May 3, 2024

Conversation

Jaybsoni
Copy link
Contributor

@Jaybsoni Jaybsoni commented May 3, 2024

Context:
Rename the accepted values for the method keyword argument in the TrotterProduct class to be more verbose.

Description of the Change:
Change:

  • method="one-norm" --> method="one-norm-bound"
  • method="commutator" --> method="commutator-bound"

Copy link
Contributor

github-actions bot commented May 3, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Jaybsoni Jaybsoni requested review from soranjh and DSGuala May 3, 2024 13:38
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DSGuala
Copy link
Contributor

DSGuala commented May 3, 2024

Nice! Thanks for getting this in so fast.

@trbromley trbromley added this to the v0.36 milestone May 3, 2024
@trbromley trbromley added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label May 3, 2024
@astralcai astralcai enabled auto-merge (squash) May 3, 2024 14:00
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v0.36.0-rc0@be9f86a). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.36.0-rc0    #5637   +/-   ##
==============================================
  Coverage               ?   99.69%           
==============================================
  Files                  ?      412           
  Lines                  ?    38336           
  Branches               ?        0           
==============================================
  Hits                   ?    38218           
  Misses                 ?      118           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astralcai astralcai merged commit d5f436e into v0.36.0-rc0 May 3, 2024
38 checks passed
@astralcai astralcai deleted the error_method_rename branch May 3, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-ready ✔️ All tests pass and the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants