Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change casting rules for StateMP to avoid copy in Lightning #5995

Merged
merged 8 commits into from
Jul 17, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Jul 12, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
The changes made in #5547 led to a performance regression in Lightning because a superfluous state vector copy is made when adding 0.j, which was introduced to cast the output to complex.

Description of the Change:
Use qml.math.cast instead.

Benefits:
Avoid unnecessary sum of 0.j

Possible Drawbacks:

Related GitHub Issues:
[sc-65127]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (94b5533) to head (b20cb0e).
Report is 290 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5995      +/-   ##
==========================================
- Coverage   99.66%   99.65%   -0.01%     
==========================================
  Files         427      427              
  Lines       40983    40694     -289     
==========================================
- Hits        40845    40555     -290     
- Misses        138      139       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review July 15, 2024 14:05
@vincentmr vincentmr requested review from a team and removed request for a team July 15, 2024 18:33
@vincentmr vincentmr requested a review from a team July 15, 2024 19:29
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vincentmr vincentmr enabled auto-merge (squash) July 17, 2024 17:58
@vincentmr vincentmr merged commit ddeb50c into master Jul 17, 2024
40 checks passed
@vincentmr vincentmr deleted the state_cast branch July 17, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants