Added Kitaev model Hamiltonian #6174

ddhawan11 · 2024-08-28T19:07:00Z

Context:
Added Kitaev Model

Description of the Change:
Added functionality to create Kitaev model Hamiltonian.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-71957]

pennylane/spin/spin_hamiltonian.py

github-actions · 2024-09-03T15:32:46Z

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

codecov · 2024-09-03T16:11:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (de54c54) to head (631307f).
Report is 6 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6174   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         444      444           
  Lines       42133    42198   +65     
=======================================
+ Hits        42008    42075   +67     
+ Misses        125      123    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pennylane/spin/spin_hamiltonian.py

tests/spin/test_lattice.py

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

austingmhuang

Thanks @ddhawan11 . Looks good. Left some initial comments.

pennylane/spin/lattice.py

austingmhuang

Some more small comments about the docstrings...

pennylane/spin/lattice.py

pennylane/spin/spin_hamiltonian.py

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

pennylane/spin/spin_hamiltonian.py

soranjh

Thanks @ddhawan11 looks good overall, but the the _get_custom_edges function still needs 1) an example, 2) proper comments indicating, clearly, what each block is doing.

Also not sure using | instead of or looks nice in the built docs. I will approve when these points are addressed.

pennylane/spin/lattice.py

pennylane/spin/spin_hamiltonian.py

tests/spin/test_lattice.py

pennylane/spin/lattice.py

doc/releases/changelog-dev.md

pennylane/spin/lattice.py

soranjh

Thanks @ddhawan11, looks good!

austingmhuang

Great work @ddhawan11. Just a small comment about the error raising, but it is not blocking, fine as it is as well.

doc/releases/changelog-dev.md

pennylane/spin/lattice.py

tests/spin/test_lattice.py

[skip ci] Added Kitaev model Hamiltonian

7f63b0f

ddhawan11 requested a review from soranjh August 28, 2024 19:07

ddhawan11 commented Aug 28, 2024

View reviewed changes

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

ddhawan11 and others added 3 commits August 28, 2024 15:10

Update pennylane/spin/spin_hamiltonian.py

756dd76

Cleaned up some

ed029a5

Merge branch 'master' into kitaev_model

7177342

ddhawan11 requested review from obliviateandsurrender and austingmhuang September 3, 2024 15:30

ddhawan11 marked this pull request as ready for review September 3, 2024 15:32

obliviateandsurrender reviewed Sep 3, 2024

View reviewed changes

pennylane/spin/spin_hamiltonian.py Show resolved Hide resolved

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

ddhawan11 and others added 2 commits September 4, 2024 18:09

Merge branch 'master' into kitaev_model

4026924

docstring fix

1db7eb5

ddhawan11 requested a review from obliviateandsurrender September 4, 2024 13:37

obliviateandsurrender reviewed Sep 4, 2024

View reviewed changes

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

tests/spin/test_lattice.py Show resolved Hide resolved

Update pennylane/spin/spin_hamiltonian.py

c15a6f5

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

austingmhuang reviewed Sep 4, 2024

View reviewed changes

pennylane/spin/lattice.py Show resolved Hide resolved

pennylane/spin/lattice.py Outdated Show resolved Hide resolved

pennylane/spin/lattice.py Outdated Show resolved Hide resolved

ddhawan11 and others added 3 commits September 5, 2024 08:42

Added custom_edges example

702864f

Merge branch 'master' into kitaev_model

f0cbfbe

docstring fix

4a4d6bf

ddhawan11 requested review from obliviateandsurrender and austingmhuang September 5, 2024 13:30

docstring fix

e766e2e

austingmhuang reviewed Sep 5, 2024

View reviewed changes

pennylane/spin/lattice.py Outdated Show resolved Hide resolved

pennylane/spin/lattice.py Show resolved Hide resolved

pennylane/spin/lattice.py Outdated Show resolved Hide resolved

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

ddhawan11 and others added 5 commits September 6, 2024 05:10

Update pennylane/spin/lattice.py

9f6e9e4

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

f47b3ec

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/lattice.py

902be92

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/lattice.py

201fab9

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Merge branch 'master' into kitaev_model

17317b0

ddhawan11 and others added 5 commits September 16, 2024 11:17

Update pennylane/spin/lattice.py

d80c494

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/spin/lattice.py

5b940d4

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/spin/lattice.py

acd399d

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/spin/lattice.py

9b4579e

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Addressed comments

c4db4eb

ddhawan11 requested a review from soranjh September 16, 2024 17:12

ddhawan11 and others added 2 commits September 17, 2024 14:16

Merge branch 'master' into kitaev_model

8cf6bbb

Merge branch 'master' into kitaev_model

5ac6844

obliviateandsurrender reviewed Sep 17, 2024

View reviewed changes

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

minor docstring fix

f600efb

soranjh requested changes Sep 19, 2024

View reviewed changes

ddhawan11 and others added 3 commits September 20, 2024 07:27

Addressed comments

775ba90

used dictionary for lattice mapping

81c9766

Merge branch 'master' into kitaev_model

d92d431

ddhawan11 commented Sep 20, 2024

View reviewed changes

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved

Update doc/releases/changelog-dev.md

f12a173

ddhawan11 commented Sep 20, 2024

View reviewed changes

pennylane/spin/lattice.py Outdated Show resolved Hide resolved

Update pennylane/spin/lattice.py

3eadc14

ddhawan11 requested review from soranjh and austingmhuang September 20, 2024 14:29

soranjh approved these changes Sep 20, 2024

View reviewed changes

austingmhuang approved these changes Sep 20, 2024

View reviewed changes

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved

pennylane/spin/lattice.py Outdated Show resolved Hide resolved

ddhawan11 and others added 2 commits September 20, 2024 13:28

resolved conflicts

b45dd17

Merge branch 'master' into kitaev_model

2c0c7b0

ddhawan11 enabled auto-merge (squash) September 20, 2024 17:36

ddhawan11 commented Sep 20, 2024

View reviewed changes

tests/spin/test_lattice.py Outdated Show resolved Hide resolved

ddhawan11 and others added 2 commits September 20, 2024 13:40

Update tests/spin/test_lattice.py

d9f9144

Fixed black

631307f

ddhawan11 merged commit 79cb2eb into master Sep 20, 2024
37 checks passed

ddhawan11 deleted the kitaev_model branch September 20, 2024 18:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Kitaev model Hamiltonian #6174

Added Kitaev model Hamiltonian #6174

ddhawan11 commented Aug 28, 2024

github-actions bot commented Sep 3, 2024

codecov bot commented Sep 3, 2024 •

edited

Loading

austingmhuang left a comment

austingmhuang left a comment

soranjh left a comment

soranjh left a comment

austingmhuang left a comment

Added Kitaev model Hamiltonian #6174

Added Kitaev model Hamiltonian #6174

Conversation

ddhawan11 commented Aug 28, 2024

github-actions bot commented Sep 3, 2024

codecov bot commented Sep 3, 2024 • edited Loading

Codecov Report

austingmhuang left a comment

Choose a reason for hiding this comment

austingmhuang left a comment

Choose a reason for hiding this comment

soranjh left a comment

Choose a reason for hiding this comment

soranjh left a comment

Choose a reason for hiding this comment

austingmhuang left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 3, 2024 •

edited

Loading