Add additional lattice models #6237
Merged
+557
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddhawan11
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6237 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 444 444
Lines 42133 42149 +16
=======================================
+ Hits 42008 42026 +18
+ Misses 125 123 -2 ☔ View full report in Codecov by Sentry. |
soranjh
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Thanks @ddhawan11, looks good overall. We just need stronger tests for the correctness of the lattices.
soranjh
approved these changes
Sep 19, 2024
obliviateandsurrender
approved these changes
Sep 19, 2024
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
soranjh
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Thanks @ddhawan11, looks good to me. Just left a final question.
austingmhuang
approved these changes
Sep 20, 2024
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
soranjh
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Adds additional lattice templates for the lattice class.
Description of the Change:
Adds lattice models: Lieb, Cubic, Body centered cubic and Face centered cubic.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-70987]