Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README positioning for researchers #6411

Merged
merged 49 commits into from
Nov 8, 2024
Merged

Conversation

justinpickering
Copy link
Contributor

@justinpickering justinpickering commented Oct 17, 2024

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@justinpickering
Copy link
Contributor Author

justinpickering commented Oct 18, 2024

Hey @josh146 @ixfoduap @Lorraine-at-Xanadu - I've added you as reviewers to this PR for updating the PennyLane README. The PR description includes a link to the EPIC that provides context.

To get the ball rolling, I've made the current changes (so far):

  • Overview section:

    • Updated messaging: The definitive open-source Python framework for quantum programming. Built by researchers, for research..
    • Removed Train a quantum computer the same way as a neural network. copy.
  • Key Features section:

    • Updated to reflect the features highlighted in the pennylane.ai /features page. Note, the new 'Research' page will also include these features, so we should be consistent here as well.
    • Added link to our /features page.
  • Getting started section:

    • Updated copy.
    • Added "Key resources" section with links to the new Codebook and Coding Challenges
    • Replaced "what is QML" link, with more general "Learn quantum programming" link.
  • Demos section:

    • Renamed from Tutorials and demonstrations to Demos
    • revised and removed some copy
  • Removed the Videos section entirely (videos are already referenced in the Getting started section)

  • Added a Research Applications section:

    • Includes placeholder links for papers.
    • Thoughts? Purely an idea inspired by designs of the new research page (which will include a section with links to papers).

Please let me know if any feedback on changes proposed above, or anywhere on the README page in light of our goal to improve positioning for researchers. Also, I'd appreciate your thoughts on:

  • Badges section: are there any other important badges that we can display?
  • Images: the majority are outdated (overview, key features, Getting started, Demos). I will discuss with Tarik if there are any improvements we can make here.

@justinpickering justinpickering marked this pull request as ready for review October 18, 2024 15:27
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (ee294b6) to head (4c00410).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6411   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files         456      456           
  Lines       43258    43258           
=======================================
  Hits        42973    42973           
  Misses        285      285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @justinpickering! Already a big improvement

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
justinpickering and others added 5 commits October 18, 2024 17:39
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
@Lorraine-at-Xanadu
Copy link

Hey @justinpickering!

  1. I recommend revising the sentence related to the PennyLane Discussion Forum to the following:

Join the PennyLane Discussion Forum to connect with the quantum community, get support, and engage directly with our team. It’s the perfect place to share ideas, ask questions, and collaborate with fellow researchers and developers!

  1. The Code of Conduct on GitHub is different from the Code of Conduct on PennyLane.ai. Should they be the same? If not, is the one on GitHub up-to-date?

image

@Lorraine-at-Xanadu
Copy link

Hi @justinpickering!

  1. I recommend changing 'developer hub' to 'Development guide' for consistency with the head on the webpage.
  2. The page linking from 'contributions page' looks like it may be a bit out of date. For example, the first few lines still have a QML focus. Do we respond to users in the PennyLane Discussion Forum within "a couple of hours"? There are opportunities to change the messaging so it speaks to researchers.

image

@Lorraine-at-Xanadu
Copy link

Overall, this looks really good, @justinpickering. Thank you very much for taking this on. 🙏

@justinpickering
Copy link
Contributor Author

Thank you for the feedback, @Lorraine-at-Xanadu!

  1. I recommend revising the sentence related to the PennyLane Discussion Forum to the following:

Join the PennyLane Discussion Forum to connect with the quantum community, get support, and engage directly with our team. It’s the perfect place to share ideas, ask questions, and collaborate with fellow researchers and developers!

This has been updated (98673ef) ✅

  1. The Code of Conduct on GitHub is different from the Code of Conduct on PennyLane.ai. Should they be the same? If not, is the one on GitHub up-to-date?

I am not entirely sure here, as this is a contributor code of conduct whose purpose may be different.
@josh146 - would we need to update our CoC link to include the Code of Conduct on PennyLane.ai. Is the contributor CoC still valid?

I recommend changing 'developer hub' to 'Development guide' for consistency with the head on the webpage.

This has been updated. (4b6f93c) ✅

The page linking from 'contributions page' looks like it may be a bit out of date. For example, the first few lines still have a QML focus. Do we respond to users in the PennyLane Discussion Forum within "a couple of hours"? There are opportunities to change the messaging so it speaks to researchers.

This page mimics the contributions page in our documentation though it looks like it hasn't been updated since 2022 (based on commit history). Happy to suggest updates to this page as well!

@josh146
Copy link
Member

josh146 commented Oct 22, 2024

This page mimics the contributions page in our documentation though it looks like it hasn't been updated since 2022 (based on commit history). Happy to suggest updates to this page as well!

Good idea to update this page! Let's do it as a separate epic/task.

I am not entirely sure here, as this is a contributor code of conduct whose purpose may be different.
@josh146 - would we need to update our CoC link to include the Code of Conduct on PennyLane.ai. Is the contributor CoC still valid?

Good point -- the one on GitHub is more for development discussion and contributions, and the one on the website seems more geared towards events.

for now let's leave them as is, but make a note to revisit this to understand if they should be merged. We can also have a link on the Github CoC pointing to the website one.

@justinpickering
Copy link
Contributor Author

Good idea to update this page! Let's do it as a separate epic/task.

Sounds good 👍

for now let's leave them as is, but make a note to revisit this to understand if they should be merged. We can also have a link on the Github CoC pointing to the website one.

I'll create a backlog ticket to revisit this.

@justinpickering
Copy link
Contributor Author

[sc-76991]

@justinpickering justinpickering enabled auto-merge (squash) November 6, 2024 22:01
Copy link

@Lorraine-at-Xanadu Lorraine-at-Xanadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @justinpickering.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@justinpickering justinpickering added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Nov 8, 2024
@justinpickering justinpickering enabled auto-merge (squash) November 8, 2024 20:02
@albi3ro albi3ro added the urgent Mark a pull request as high priority label Nov 8, 2024
@justinpickering justinpickering merged commit 7153fe7 into master Nov 8, 2024
45 checks passed
@justinpickering justinpickering deleted the readme-update branch November 8, 2024 21:57
mudit2812 pushed a commit that referenced this pull request Nov 11, 2024
**Context:**
See EPIC: [[P1] Update PennyLane GitHub repo README content positioning
for
researchers](https://app.shortcut.com/xanaduai/epic/76283/p1-update-content-in-pennylane-github-repository-readme?cf_workflow=500000005&ct_workflow=all&group_by=none)

---------

Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-ready ✔️ All tests pass and the PR is ready to be merged. urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants