[Capture] iterative_qpe uses qml control flow functions
#6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6680 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 474 474
Lines 44617 44628 +11
=======================================
+ Hits 44448 44459 +11
Misses 169 169 ☔ View full report in Codecov by Sentry. |
mudit2812
reviewed
Dec 11, 2024
Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai>
PietropaoloFrisoni
approved these changes
Dec 11, 2024
mudit2812
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The capture project allows us to convert more complicated hybrid workflows into jaxpr.
Description of the Change:
Makes it so that
iterative_qpecan be compactly captured into jaxpr.Benefits:
Possible Drawbacks:
The testing in this PR is horrible, but I don't really have a better way of doing it. The produced jaxpr is rather complicated, the produced jaxpr is not compatible with
plxpr_to_tape, we currently only use single-branch-statistics to simulate MCM's, and we can't post-process MCM's.Related GitHub Issues:
[sc-72592]