Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial on studying chemical reactions using VQE #261

Merged
merged 318 commits into from
Jul 23, 2021

Conversation

varunrishi
Copy link
Contributor

@varunrishi varunrishi commented Apr 26, 2021

A tutorial on to using Pennylane to study chemical reactions and constructing potential energy surfaces.
[ Work-In-Progress ]

Title: Studying Chemical reactions and constructing potential energy surfaces using VQE

Summary: A basic introduction on how to study chemical reactions using quantum computing algorithms such as VQE. We introduce the idea of potential energy surfaces (PES) and then show how to construct them for diatomic bond dissociations and a simple hydrogen exchange reaction. Finally, it is shown that useful reaction parameters such as activation energy barrier and rate constant could be calculated from the PES

@varunrishi varunrishi changed the base branch from master to dev April 26, 2021 12:37
@josh146 josh146 changed the title [Not ready to Merge yet] tutorial on studying chemical reactions using VQE [WIP] tutorial on studying chemical reactions using VQE Apr 26, 2021
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review of the introduction. Will continue review tomorrow

demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall content of the tutorial is great! It's very useful to finally have an explanation of how to build a PES and use it to study chemical reactions.

The actual execution needs more work, both on the text and code. I've left suggestions for improvements.

I still have to review from line 380 onwards

demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the last part of the tutorial is the most important one, yet many of the crucial calculations are not being explicitly performed.

Remember, one of the main goals of a tutorial is to give readers a template of code that they can basically copy-paste to solve their own specific problems.

demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
@ixfoduap ixfoduap marked this pull request as draft April 30, 2021 13:46
@ixfoduap ixfoduap marked this pull request as ready for review May 3, 2021 13:32
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tutorial is in better shape, but it still needs a lot of work to meet the high standards expected from everything we do at Xanadu. Please address my comments with utmost urgency so that we can finally open the PR for other reviewers as soon as possible

demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
demonstrations/tutorial_vqe_bond_dissociation.py Outdated Show resolved Hide resolved
varunrishi and others added 2 commits May 10, 2021 13:35
JM suggests

Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
Co-authored-by: ixfoduap <40441298+ixfoduap@users.noreply.github.com>
@glassnotes glassnotes changed the base branch from dev to master July 23, 2021 13:26
demos_basics.rst Outdated Show resolved Hide resolved
@co9olguy co9olguy merged commit d756a41 into master Jul 23, 2021
@co9olguy co9olguy deleted the qchem_bond_dissociation branch July 23, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants