-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing qml.ExpvalCost
from demos due to deprecation
#506
Conversation
qml.ExpvalCost
from demos due to deprecation
@@ -481,33 +481,7 @@ def circuit(weights): | |||
# terms of ``RX`` and ``RY`` rotations. Check out the :mod:`qml.grouping <pennylane.grouping>` | |||
# documentation for more details on its provided functionality and how it works. | |||
# | |||
# What happens, though, if we (in a moment of reckless abandon!) ask a QNode to simultaneously |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is removed because non-commuting observables are now supported: PennyLaneAI/pennylane#2587
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those changes it looks good to me 💯 What about vqe_parallel
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
After deprecating
ExpvalCost
, PennyLaneAI/pennylane#2571, need to adjust the following demos:The latter, vqe_parallel turns out to be trickier than expected because it is very old and actually not supported anymore.
A previous PR was created #504 but deleted due to base branch issues.