Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing qml.ExpvalCost from demos due to deprecation #506

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Conversation

Qottmann
Copy link
Collaborator

After deprecating ExpvalCost, PennyLaneAI/pennylane#2571, need to adjust the following demos:

The latter, vqe_parallel turns out to be trickier than expected because it is very old and actually not supported anymore.

A previous PR was created #504 but deleted due to base branch issues.

@Qottmann Qottmann requested a review from rmoyard June 14, 2022 16:27
@Qottmann Qottmann changed the title Fix expvalcost Removing qml.ExpvalCost from demos due to deprecation Jun 14, 2022
@@ -481,33 +481,7 @@ def circuit(weights):
# terms of ``RX`` and ``RY`` rotations. Check out the :mod:`qml.grouping <pennylane.grouping>`
# documentation for more details on its provided functionality and how it works.
#
# What happens, though, if we (in a moment of reckless abandon!) ask a QNode to simultaneously
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is removed because non-commuting observables are now supported: PennyLaneAI/pennylane#2587

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 506
  • Deployment SHA: f8bdc296d64a1b94aff1fd99a93d6ce2e7513d5b
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes it looks good to me 💯 What about vqe_parallel?

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@rmoyard rmoyard merged commit 5649203 into dev Jun 14, 2022
@rmoyard rmoyard deleted the fix-expvalcost branch June 14, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants