fix(attachment:filename): fix the mime filename header #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the bug happens only for filenames that contain non ascii characters like latin or german umlauts now the content-type name and content-disposition filename behaves correctly according to the rfc2231 and rfc2047
sassman
force-pushed
the
fix/mime-filename
branch
from
112ba14
to
eb73c9a
Compare
|
@sassman thanks for the PR. would you please provide some test scripts against it to prove it works, if possible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bug happens only for filenames that contain non ascii characters like latin or german umlauts
now the content-type name and content-disposition filename behaves correctly according to the rfc2231 and rfc2047