Simplify strict.pm #22848
Open
Simplify strict.pm #22848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the weird action at a distance where bits() modifies $^H itself but then also returns a value to be NANDed or ORed with it. Inlining the bits() logic in this way also turns up an optimization opportunity which the next commit will exploit.
|
Needs a version bump in lib/strict.pm. |
|
@jkeenan Yes, but that’s the least of the problems. Turns out |
|
(OTOH this has unearthed the fact that some of the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strict.pm is slightly confusing to follow. Restructuring it to make it more legible makes it more apparent that there are some optimizations to be had, which make it no harder to understand, so I’ve taken that opportunity as well.