Call engine.logger.* hooks around logging a message #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hook names were defined, but they were never called. Call them in an anround modifier on the log method (similar to where session engine hooks are called). Either being lazy or wise; these hooks are passed the logging engine object, and all params to the log method. Tests include an example of changing the log level before the message is passed to the logger.
|
👍 I'm thinking of some really weird ways to use this - like it a lot. |
|
👍 Nice! |
|
👍 That's awesome. Like @SysPete, I am anxious to find ways to (ab)use this! |
|
Merged. Thanks everyone for taking a look! My first plan for this in untangling D2::P::LR (per #1125). |
|
@veryrusty Can you detail some of the plan? |
|
D2::P::LR does two things
|
xsawyerx
added a commit
that referenced
this pull request
Apr 19, 2016
[ BUG FIXES ]
* GH #1102: Handle multiple '..' in file path utilities.
(Oleg A. Mamontov, Peter Mottram)
* GH #1114: Fix missing prereqs as reported by CPANTS.
(Mohammad S Anwar)
* GH #1128: Shh warning if optional megasplat is not present.
(David Precious)
* GH #1139: Fix incorrect Content-Length header added by AutoPage
handler (Michael Kröll, Russell Jenkins)
* GH #1144: Change tt tags to span in skel (Jason Lewis)
* GH #1046: "no_server_tokens" configuration option doesn't work.
(Sawyer X)
# GH #1155, #1157: Fix megasplat value splitting when there are empty
trailing path segments. (Tatsuhiko Miyagawa, Russell Jenkins)
NOTE: Paths matching a megasplat that end with a '/' will now include
an empty string as the last value. For the route pattern '/foo/**',
the path '/foo/bar', the megasplat gives ['bar'], whereas '/foo/bar/'
now gives ['bar','']. Joining the array of megasplat values will now
always be the string matched against for the megasplit.
[ DOCUMENTATION ]
* GH #1119: Improve the deployment documentation. (Andrew Beverley)
* GH #1123: Document import of utf8 pragma. (Victor Adam)
* GH #1132: Fix spelling mistakes in POD (Gregor Herrmann)
* GH #1134: Fix spelling errors detected by codespell (James McCoy)
* GH #1153: Fix POD rendering error. (Sawyer X)
[ ENHANCEMENTS ]
* GH #1129: engine.logger.* hooks are called around logging a message.
(Russell @veryrusty Jenkins)
* GH #1146: Cleaner display of error context (Vernon Lyon)
* GH #1085: Add consistent keywords for accessing headers;
'request_header' for request, 'response_header', 'response_headers'
and 'push_response_header' for response. (Russell @veryrusty Jenkins)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook names were defined, but they were never called.
Call them in an around modifier on the log method (similar to where session engine hooks are called). Either being lazy or wise; these hooks are passed the logging engine object, and all params to the log method.
Tests include an example of changing the log level before the message is passed to the logger.