Fix public_dir option #1295
Closed
Fix public_dir option #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem in GH #975 is that we decide what the public_dir should be before we read the configuration, which might give a different public dir. This can be resolved by deciding this later, during the to_app time. The additional problem this exposes is that public_dir created from both DANCER_PUBLIC and "public_dir" configruation option does not take into account the location (app dir). I don't think that's correct. The test shows this in the config.yml file.
|
👍 |
|
@PerlDancer/core, any other approvals? |
|
seems legit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #975.