Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest polkadot-v0.9.33 #1060

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Upgrade to latest polkadot-v0.9.33 #1060

merged 1 commit into from
Dec 6, 2022

Conversation

jasl
Copy link
Collaborator

@jasl jasl commented Dec 5, 2022

paritytech/substrate@polkadot-v0.9.32...polkadot-v0.9.33

Please also review upstream changes, this version commits is much, I may missing something
Notable changes:

pallet-contracts supports Indeterministic has included, but it seems set AllowIndeterministic will panic by

---- runtime::tests::gas_limit_works stdout ----
thread 'runtime::tests::gas_limit_works' panicked at 'Expected Ok(_). Got Err(
    Module(
        ModuleError {
            index: 4,
            error: [
                29,
                0,
                0,
                0,
            ],
            message: Some(
                "Indeterministic",
            ),
        },
    ),
)', crates/pink/src/runtime.rs:385:9

set Deterministic which keep current behavior is fine, maybe need some refactor to enable it?

@jasl
Copy link
Collaborator Author

jasl commented Dec 5, 2022

Subxt made some changes that need refactor pherry too, but I don't upgrade pherry in this PR

@jasl jasl requested a review from kvinwang December 5, 2022 20:20
@jasl jasl marked this pull request as ready for review December 5, 2022 20:20
Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasl jasl merged commit 760e904 into master Dec 6, 2022
@jasl jasl deleted the polkadot-v0.9.33 branch December 6, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants