pruntime: Optional use RocksDB/redb as trie state backend

Cargo.toml

@@ -55,6 +55,7 @@ members = [
 	"crates/phala-types",
 	"crates/phala-git-revision",
 	"crates/prpc",
+	"crates/immutable_env",
 	"crates/prpc-build",
 	"crates/phactory",
 	"crates/phactory/api",

crates/immutable_env/Cargo.toml

@@ -0,0 +1,11 @@
+[package]
+name = "immutable_env"
+version = "0.1.0"
+edition = "2021"
+description = "Immutable environment variables which are taken from the environment when the program starts and never change."
+license = "MIT"
+repository = "https://github.com/Phala-Network/phala-blockchain"
+authors = ["Kevin Wang <wy721@qq.com>"]
+
+[dependencies]
+ctor = "0.2"

crates/immutable_env/src/lib.rs

@@ -0,0 +1,16 @@
+//! Immutable environment variables which are taken from the environment when the program starts
+//! and never change.
+
+#[ctor::ctor]
+static VALUES: std::collections::HashMap<String, String> = std::env::vars().collect();
+
+pub fn get(key: &str) -> Option<String> {
+    VALUES.get(key).cloned()
+}
+
+#[test]
+fn it_works() {
+    let init = std::env::var("PATH").ok();
+    std::env::set_var("PATH", "foo");
+    assert_eq!(get("PATH"), init);
+}

crates/phactory/src/contracts/pink.rs

@@ -279,7 +279,7 @@ impl OCalls for RuntimeHandle<'_> {
     }
 
     fn storage_get(&self, key: Vec<u8>) -> Option<Vec<u8>> {
-        self.cluster.storage.get(&key).map(|(_rc, val)| val.clone())
+        self.cluster.storage.get(&key).map(|(_rc, val)| val)
     }
 
     fn storage_commit(&mut self, _root: Hash, _changes: StorageChanges) {
@@ -410,6 +410,11 @@ impl OCalls for RuntimeHandleMut<'_> {
     }
 
     fn storage_commit(&mut self, root: Hash, changes: StorageChanges) {
+        // The underlying RocksDB would reject to commit to a snapshot.
+        if !context::get().mode.is_transaction() {
+            return;
+        }
+        info!("commit state root: {:?}", root);
         self.cluster.storage.commit(root, changes);
     }
 
@@ -641,15 +646,13 @@ impl Cluster {
                     context::using(&mut ctx, move || {
                         context::using_entry_contract(contract_id.clone(), || {
                             let mut runtime = self.runtime_mut(log_handler);
-                            if deposit > 0 {
-                                runtime.deposit(origin.clone(), deposit);
-                            }
                             let args = TransactionArguments {
                                 origin,
                                 transfer,
                                 gas_limit: WEIGHT_REF_TIME_PER_SECOND * 10,
                                 gas_free: true,
                                 storage_deposit_limit: None,
+                                deposit,
                             };
                             let ink_result = runtime.call(contract_id, input_data, mode, args);
                             let effects = if mode.is_estimating() {
@@ -721,15 +724,13 @@ impl Cluster {
                 let log_handler = context.log_handler.clone();
                 context::using(&mut ctx, move || {
                     let mut runtime = self.runtime_mut(log_handler);
-                    if deposit > 0 {
-                        runtime.deposit(origin.clone(), deposit);
-                    }
                     let args = TransactionArguments {
                         origin,
                         transfer,
                         gas_limit: WEIGHT_REF_TIME_PER_SECOND * 10,
                         gas_free: true,
                         storage_deposit_limit: None,
+                        deposit,
                     };
                     let ink_result = runtime.instantiate(
                         code_hash,
@@ -778,6 +779,7 @@ impl Cluster {
                     gas_limit,
                     gas_free,
                     storage_deposit_limit,
+                    deposit: 0,
                 };
 
                 let mut runtime = self.runtime_mut(context.log_handler.clone());

crates/phactory/src/contracts/support.rs

@@ -209,6 +209,7 @@ impl Contract {
             gas_free: false,
             storage_deposit_limit: None,
             gas_limit,
+            deposit: 0,
         };
         let mut handle = env.contract_cluster.runtime_mut(env.log_handler.clone());
         _ = handle.call(

crates/phactory/src/prpc_service.rs

@@ -1324,10 +1324,13 @@ impl<Platform: pal::Platform + Serialize + DeserializeOwned> PhactoryApi for Rpc
             // the singleton phactory. This way, we can avoid blocking the RPC server.
             info!("Cloning Phactory to do RCU dispatch...");
             let cloned = phactory.clone();
+            // Because the underlying KVDB of the cloned phactory is readonly, so we use the original
+            // phactory to dispatch the blocks.
+            let origin = std::mem::replace(&mut **phactory, cloned);
             // We set rcu_dispatching = true to avoid a reentrant call to dispatch_blocks which
             // would cause a state inconsistency.
             phactory.rcu_dispatching = true;
-            cloned
+            origin
         };
         // Start to dispatch the blocks with the cloned phactory without locking the singleton phactory.
         info!("Unlocked Phactory, dispatching blocks...");

crates/phactory/src/storage.rs

@@ -67,6 +67,12 @@ mod storage_ext {
     }
 
     impl ChainStorage {
+        pub fn default_memdb() -> Self {
+            Self {
+                trie_storage: TrieStorage::default_memdb(),
+            }
+        }
+
         fn get_raw(&self, key: impl AsRef<[u8]>) -> Option<Vec<u8>> {
             self.trie_storage.get(key)
         }

crates/phactory/src/system/gk.rs

@@ -1609,7 +1609,7 @@ pub mod tests {
 
     fn with_block(block_number: chain::BlockNumber, call: impl FnOnce(&BlockInfo)) {
         // GK never use the storage ATM.
-        let storage = crate::ChainStorage::default();
+        let storage = crate::ChainStorage::default_memdb();
         let mut recv_mq = phala_mq::MessageDispatcher::new();
         let mut send_mq = phala_mq::MessageSendQueue::new();
         let block = BlockInfo {

crates/phactory/src/system/mod.rs

@@ -1293,6 +1293,7 @@ impl<Platform: pal::Platform> System<Platform> {
                             gas_limit,
                             gas_free: false,
                             storage_deposit_limit,
+                            deposit: 0,
                         };
                         let mut runtime = cluster.runtime_mut(log_handler.clone());
                         let _result = runtime.instantiate(

crates/phala-trie-storage/Cargo.toml

@@ -18,7 +18,14 @@ serde = { version = "1.0", default-features = false, features = ["derive", "allo
 hash-db = "0.16.0"
 trie-db = "0.27.1"
 im = { version = "15", features = ["serde"] }
+rocksdb = "0.21"
+librocksdb-sys = "0.11.0"
 log = "0.4"
+environmental = "1"
+immutable_env = { version = "0.1.0", path = "../immutable_env" }
+atomic = "0.5.3"
+redb = "1"
+ouroboros = "0.17"
 
 [dev-dependencies]
 sp-runtime = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43" }
@@ -28,6 +35,8 @@ hex = "0.4"
 serde_json = "1.0"
 impl-serde = "0.4.0"
 keccak-hasher = "0.16.0"
+serde_cbor = "0.11.2"
+tempfile = "3"
 
 [features]
 default = ["serde"]