Upgrade to Polkadot v1.0.0 #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good. We need to add the migration to our pink runtime(Let me do it later). |
|
@kvinwang can you help to take a look of the e2e failed? |
kvinwang
reviewed
Sep 5, 2023
jasl
force-pushed
the
polkadot-v1.0.0
branch
from
dcc8c27
to
0a00977
Compare
kvinwang
reviewed
Sep 6, 2023
| @@ -30,35 +30,35 @@ expression: "travel_types::<blocks::SyncParachainHeaderReq>()" | |||
| }, | |||
| { | |||
| "name": "Hash", | |||
| "type": 3 | |||
| "type": null | |||
There was a problem hiding this comment.
It's strange the type changed to null.
These snapshots detects whether the data structure of blocks synced into pRuntime changes.
We need to check the compatibility:
- whether the old verions of pRuntime accept the new block data.
- whether the new pRuntime accept block data from old version of chain node.
And we'd better make clear understand on what would these structure changes affect.
There was a problem hiding this comment.
I've digged into this, the null here is due to the #[derive(TypeInfo)] now trims all zero sized types.
So, there are no actual data structure changes.
jasl
force-pushed
the
polkadot-v1.0.0
branch
from
dbf9a5d
to
0715e06
Compare
kvinwang
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate@polkadot-v0.9.43...polkadot-v1.0.0
Breaking changes:
GenesisBuild<T,I>deprecated.BuildGenesisConfigadded. paritytech/substrate#14306Blocktoframe_systeminstead ofconstruct_runtimeand removesHeaderandBlockNumberparitytech/substrate#14437Few changes about pallet-contracts:
parity-wasm-based towasmi-based module validation paritytech/substrate#14449